-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create personal detail optimistic data when inviting member to the room #32788
Conversation
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-11.at.21.56.05.android.mp4Android: mWeb ChromeScreen.Recording.2023-12-11.at.21.58.47.-.android.chrome.moviOS: NativeScreen.Recording.2023-12-11.at.22.02.17.-.ios.moviOS: mWeb SafariScreen.Recording.2023-12-11.at.22.01.06.-.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2023-12-11.at.20.16.28.-.web.movMacOS: DesktopScreen.Recording.2023-12-11.at.21.52.44.-.desktop.mov |
@dukenv0307 I found a bug that, when we invite a member in offline, the invited member is not greyed out. Screen.Recording.2023-12-11.at.20.16.28.mov |
@hoangzinh I think this is out of scope of this issue because in stanging or production if we invite a user whom the user has personal detail, the behavior is the same. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.12-0 🚀
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.12-0 🚀
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.12-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀
|
Details
Create personal detail optimistic data when inviting member to the room
Fixed Issues
$ #32712
PROPOSAL: #32712 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-12-11.at.11.24.39.mov
Android: mWeb Chrome
Screen.Recording.2023-12-11.at.11.15.37.mov
iOS: Native
Screen.Recording.2023-12-11.at.11.32.19.mov
iOS: mWeb Safari
Screen.Recording.2023-12-11.at.11.03.58.mov
MacOS: Chrome / Safari
Screen.Recording.2023-12-11.at.10.59.43.mov
MacOS: Desktop
Screen.Recording.2023-12-11.at.11.44.29.mov